Reduce memory usage in language server by not caching AST

slackhq · Oct 6, 2023 · 52fdeb6 · 52fdeb6
1 parent 5f7faa3
commit 52fdeb6
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/file_scanner_analyzer/scanner.rs b/src/file_scanner_analyzer/scanner.rs
@@ -330,7 +330,7 @@ pub fn scan_files(
                     !test_patterns.iter().any(|p| p.matches(&str_path)),
                     &logger,
                 ) {
-                    if analyze_map.contains(&str_path) {
+                    if !config.ast_diff && analyze_map.contains(&str_path) {
                         asts.lock().unwrap().insert(**file_path, scanner_result.1);
                     }
 
@@ -405,7 +405,7 @@ pub fn scan_files(
                             !test_patterns.iter().any(|p| p.matches(&str_path)),
                             &logger.clone(),
                         ) {
-                            if analyze_map.contains(&str_path) {
+                            if !config.ast_diff && analyze_map.contains(&str_path) {
                                 local_asts.insert(*file_path, scanner_result.1);
                             }
 
@@ -490,10 +490,6 @@ pub fn scan_files(
         }
     }
 
-    codebase.classlike_infos.shrink_to_fit();
-    codebase.functionlike_infos.shrink_to_fit();
-    codebase.type_definitions.shrink_to_fit();
-
     Ok(ScanFilesResult {
         codebase,
         interner,