-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update esbuild dependencies for bundling #94
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
- Coverage 78.56% 78.31% -0.26%
==========================================
Files 17 16 -1
Lines 877 876 -1
Branches 129 130 +1
==========================================
- Hits 689 686 -3
- Misses 187 189 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
The bundling works, but I think this PR now requires exposing env vars to
The |
@filmaj I've updated this PR to get ride of the This also allows Deno to properly restrict system access like |
Sounds good, tomorrow morning I'll run a few tests on a few different apps - fresh and existing - to see how it runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested it out with a new app as well as existing app. Note that, assuming ROSI OKs access to this system API, the start hook and deno-slack-runtime also will need updates to allow access to the system osRelease
API.
Co-authored-by: Fil Maj <[email protected]>
Summary
This PR update the
esbuild
related dependency and improves support for bundling npm packages.It also gets ride of the
deps.ts
file. This prevents every hook from importing all the project dependencies when executing.Testing
slack.json
import { WebClient } from "npm:@slack/web-api";
@slack/web-api
requires--allow-sys=osRelease
to work.Requirements (place an
x
in each[ ]
)