Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle errors in the reaction add logger #2581

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Feb 11, 2024

Should fix this issue, which can happen due to a bot deleting a message while Skyra is processing the event (and in particular, fetching its reactions):
WindowsTerminal_hnfTNnSxHy

The format of the logs have changed too, taking advantage of Discord's new message tags and streamlining the embed design with the other log types:

Old New
image image

@kyranet kyranet requested a review from favna as a code owner February 11, 2024 12:53
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2de2179) 87.96% compared to head (4d1a56e) 87.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2581   +/-   ##
=======================================
  Coverage   87.96%   87.96%           
=======================================
  Files          91       91           
  Lines        3655     3656    +1     
  Branches      287      206   -81     
=======================================
+ Hits         3215     3216    +1     
  Misses        436      436           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyranet kyranet merged commit e7f4bb4 into main Feb 11, 2024
14 checks passed
@kyranet kyranet deleted the refactor/improved-reaction-add-logger branch February 11, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants