Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed resolveKey issue not formatting variables #2565

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

favna
Copy link
Member

@favna favna commented Feb 9, 2024

Important

Depends on sapphiredev/plugins#545 being merged and released

@favna favna self-assigned this Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e5e329) 88.47% compared to head (5f4531e) 88.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2565   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files          91       91           
  Lines        3617     3618    +1     
  Branches      199      278   +79     
=======================================
+ Hits         3200     3201    +1     
  Misses        411      411           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favna favna marked this pull request as ready for review February 9, 2024 20:39
@favna favna requested a review from kyranet as a code owner February 9, 2024 20:39
@favna favna merged commit 8d5d4f0 into main Feb 9, 2024
15 checks passed
@favna favna deleted the fix/fixed-resolve-key-precondition-variable-issue branch February 9, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants