Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved more issues #2533

Merged
merged 1 commit into from
Jan 1, 2024
Merged

fix: resolved more issues #2533

merged 1 commit into from
Jan 1, 2024

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Dec 31, 2023

notMutedMemberAddInitialRole was reporting errors that indicated outdated cache, which is an uncommon issue in the library. As such, I've updated the event to handle errors reactively rather than relying on the cache. This should fix the issue.

Also fixes an issue in the same event resetting the wrong key, since it was checking role's truthiness rather than initial's like the selection does.

@kyranet kyranet requested a review from favna as a code owner December 31, 2023 16:31
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (1d7cac3) 88.73% compared to head (fb08b89) 88.46%.

Files Patch % Lines
src/lib/util/common/promises.ts 20.00% 8 Missing ⚠️
src/lib/util/functions/pieces.ts 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2533      +/-   ##
==========================================
- Coverage   88.73%   88.46%   -0.27%     
==========================================
  Files          88       89       +1     
  Lines        3630     3650      +20     
  Branches      281      281              
==========================================
+ Hits         3221     3229       +8     
- Misses        403      415      +12     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favna favna merged commit 24badc9 into main Jan 1, 2024
15 checks passed
@favna favna deleted the fix/resolve-more-issues branch January 1, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants