Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: split CJS and ESM builds correctly #295

Merged
merged 3 commits into from
May 16, 2024
Merged

fix: split CJS and ESM builds correctly #295

merged 3 commits into from
May 16, 2024

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented May 16, 2024

This should fix the build errors in skyra-project/skyra#2621

favna
favna requested changes May 16, 2024
View reviewed changes
Copy link
Member

@favna favna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the script to rename the .d.ts of CJS to .d.cts. Alternatively .d.ts to .d.mts for ESM if you set "type": "module" in this package.json (that would be nice). You can find it on sapphire repos.

@kyranet kyranet merged commit 5f37869 into main May 16, 2024
5 checks passed
@kyranet kyranet deleted the refactor/update-build-configuration branch May 16, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favna favna favna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyranet @favna