-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add i18next-type-generator #273
Draft
kyranet
wants to merge
4
commits into
main
Choose a base branch
from
feat/add-i18next-type-generator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
force-pushed
the
feat/add-i18next-type-generator
branch
2 times, most recently
from
July 24, 2023 18:11
0e7a7dd
to
d723938
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
=======================================
Coverage 68.59% 68.59%
=======================================
Files 51 51
Lines 3760 3760
Branches 174 174
=======================================
Hits 2579 2579
Misses 1160 1160
Partials 21 21 ☔ View full report in Codecov by Sentry. |
kyranet
force-pushed
the
feat/add-i18next-type-generator
branch
from
July 24, 2023 18:18
d723938
to
8e3c840
Compare
kyranet
force-pushed
the
feat/add-i18next-type-generator
branch
from
August 20, 2023 15:12
64174f2
to
2da9eb9
Compare
feat: `getT` now supports namespace as a second argument feat: `getSupportedLanguageT` now supports namespace as a second argument feat: `getSupportedUserLanguageT` now supports namespace as a second argument typings: `getT` now returns `TFunction` with the correct default namespace typings: `LocalePrefixKey`'s type now doesn't force a `commands/` prefix typings: `LocalePrefixKey` now uses i18next's `nsSeparator` type instead of a hardcoded `:` typings: All functions using `TypedT` now requires `LocalePrefixKey` BREAKING CHANGE: refactor: Removed `resolveKey`, use `getSupportedLanguageT(interaction)(...args)` instead BREAKING CHANGE: refactor: Removed `resolveUserKey`, use `getSupportedUserLanguageT(interaction)(...args)` instead BREAKING CHANGE: typings: Removed `T` type utility function BREAKING CHANGE: typings: Removed `FT` type utility function BREAKING CHANGE: typings: Removed `TypedT` type utility BREAKING CHANGE: typings: Removed `TypedFT` type utility BREAKING CHANGE: typings: Removed `Value` type utility BREAKING CHANGE: typings: Removed `Values` type utility BREAKING CHANGE: typings: Removed `Difference` type utility BREAKING CHANGE: typings: `i18next.TFunction` is not longer augmented, `lng` and `ns` is not longer assumed to exist
BREAKING CHANGE: refactor: Updated `@skyra/http-framework-i18n` to `2.0.0` BREAKING CHANGE: refactor: Removed `LanguageKeys` in favour of `@skyra/i18next-type-generator` and `i18next` v23's enhanced type support
kyranet
force-pushed
the
feat/add-i18next-type-generator
branch
from
August 20, 2023 15:33
2da9eb9
to
8a1afa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a CLI tool to generate the i18next augmentations