[Core] Faster optimizer table by disabling reservation check #3280
+33
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #3159
Upper current PR, lower master (1.8s -> 0.5s): the time it takes for starting
_launch_with_confirm
to confirmation prompt.On my local laptop, it takes even longer: 127s vs 2s
Upper master, lower currnet PR
The reservation check on GCP causes the optimizer table to show up very slowly. We now disable the check by default, and add a new option to turn on it.
This issue becomes significant when H100 is involved (#3279, need to confirm)
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh