Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Disable unattended-upgrade with cloud-init #1949

Merged
merged 12 commits into from
May 11, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 11, 2023

This PR is separated from #1641, as the disabling of the unattended upgrade for AWS is more urgent for the AWS user.

We are now using the cloud-init to disable the unattended-upgrade which holds the lock for apt. The user's sudo apt install locked issue should now be fixed and deterministic.

Tested (run the relevant ones):

  • Any manual or new tests for this PR (please specify below)
    • sky launch -c test-fm ./examples/using_file_mounts.yaml (which contains the sudo apt install tree in setup)
    • sky launch -c test-fm1 --num-nodes 1 ./examples/using_file_mounts.yaml
    • sky launch -c min immediately log into the VM after provision and run sudo apt install tree
  • All smoke tests: pytest tests/test_smoke.py --aws

Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll! Some comments.

sky/templates/aws-ray.yml.j2 Outdated Show resolved Hide resolved
sky/templates/aws-ray.yml.j2 Show resolved Hide resolved
sky/authentication.py Outdated Show resolved Hide resolved
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! modulo a question on restore exceptions.

sky/authentication.py Outdated Show resolved Hide resolved
sky/backends/backend_utils.py Show resolved Hide resolved
@Michaelvll Michaelvll merged commit bbdd5b1 into master May 11, 2023
@Michaelvll Michaelvll deleted the disable-unattended-upgrade-with-cloud-init branch May 11, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants