-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Disable unattended-upgrade with cloud-init #1949
Merged
Michaelvll
merged 12 commits into
master
from
disable-unattended-upgrade-with-cloud-init
May 11, 2023
Merged
[AWS] Disable unattended-upgrade with cloud-init #1949
Michaelvll
merged 12 commits into
master
from
disable-unattended-upgrade-with-cloud-init
May 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Michaelvll! Some comments.
concretevitamin
approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! modulo a question on restore exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is separated from #1641, as the disabling of the unattended upgrade for AWS is more urgent for the AWS user.
We are now using the cloud-init to disable the
unattended-upgrade
which holds the lock forapt
. The user'ssudo apt install
locked issue should now be fixed and deterministic.Tested (run the relevant ones):
sky launch -c test-fm ./examples/using_file_mounts.yaml
(which contains thesudo apt install tree
in setup)sky launch -c test-fm1 --num-nodes 1 ./examples/using_file_mounts.yaml
sky launch -c min
immediately log into the VM after provision and runsudo apt install tree
pytest tests/test_smoke.py --aws