[WIP] Jupiter DCA support #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
skynetcap
commented
Oct 2, 2024
skynetcap
commented
- Read all Jupiter DCA accounts
Changed long to double for financial fields in JupiterPerpPosition and introduced POSITION_DIVISOR for conversion. Enhanced testGetAllJupiterPerpPositions to log formatted, comprehensive position details including entry price and leverage. (cherry picked from commit fe05a02)
Introduce the `JupiterDca` model to represent Dollar-Cost Averaging accounts. Added methods for deserialization and retrieving all DCA accounts. Updated Maven version across various modules to 1.33.0-SNAPSHOT. Enhanced `OpenBookManager` and `JupiterManager` with new methods and constants for improved functionality.
Refactored getAllDcaAccounts to handle RpcException, ensuring it returns an empty list and logs a warning in case of failure. Added a new test method getMostRecentJupiterDcaAccounts to fetch and log the most recent DCA accounts based on their index.
Updated the sorting criterion in `getMostRecentJupiterDcaAccounts` to use creation timestamp and enhanced logging details. Added filtering to display only active JupiterDca accounts based on specific conditions and included the size of the filtered list in the logs.
Introduced a new unit test `testGetOpenDcaOrders` to validate the filtering criteria for active DCA orders based on provided constraints such as next cycle, usage, and in-range amounts. This ensures proper functionality by using mock token prices and asserting the resultant order properties.
Refactor the DCA program ID from string to PublicKey type for consistency. Added a new method to retrieve DCA accounts filtered by user and updated tests to validate new functionality.
Renamed `getAllDcaAccounts` to `getDcaAccounts` in `JupiterManager` for consistency. Disabled several tests due to reliance on hardcoded accounts and potential flakiness.
Introduced JupiterUserDcaStats class for aggregating user's DCA statistics. Enhanced JupiterManager with methods for DCA order filtering, aggregation, and detailed statistics. Updated test cases to validate these new functionalities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.