Merge pull request #17 from gabrielmatau79/fix/enable-iceservers-tran…

…sport fix: 🐛 Fix bug regarding the activation of the iceServer
skymaze · Sep 20, 2024 · 02bed7c · 02bed7c
2 parents bf61434 + 1329334
commit 02bed7c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/pymediasoup/handlers/aiortc_handler.py b/pymediasoup/handlers/aiortc_handler.py
@@ -7,6 +7,7 @@
     RTCSessionDescription,
     RTCRtpTransceiver,
     MediaStreamTrack,
+    RTCConfiguration
 )
 import sdp_transform
 from .sdp import common_utils
@@ -165,7 +166,10 @@ def run(
                 "video", options.extendedRtpCapabilities
             ),
         }
-        self._pc = RTCPeerConnection()
+
+        configuration = RTCConfiguration(iceServers=iceServers)
+
+        self._pc = RTCPeerConnection(configuration=configuration)
 
         @self._pc.on("iceconnectionstatechange")
         def on_iceconnectionstatechange():

diff --git a/pymediasoup/handlers/handler_interface.py b/pymediasoup/handlers/handler_interface.py
@@ -52,7 +52,7 @@ def run(
         dtlsParameters: DtlsParameters,
         extendedRtpCapabilities: ExtendedRtpCapabilities,
         sctpParameters: Optional[SctpParameters] = None,
-        iceServers: Optional[RTCIceServer] = None,
+        iceServers: Optional[List[RTCIceServer]] = None,
         iceTransportPolicy: Optional[Literal["all", "relay"]] = None,
         additionalSettings: Optional[Any] = None,
         proprietaryConstraints: Optional[Any] = None,

diff --git a/pymediasoup/models/handler_interface.py b/pymediasoup/models/handler_interface.py
@@ -26,7 +26,7 @@ class HandlerRunOptions(BaseModel):
     iceCandidates: List[IceCandidate]
     dtlsParameters: DtlsParameters
     sctpParameters: Optional[SctpParameters]
-    iceServers: Optional[RTCIceServer]
+    iceServers: Optional[List[RTCIceServer]]
     iceTransportPolicy: Optional[Literal["all", "relay"]]
     additionalSettings: Optional[Any]
     proprietaryConstraints: Optional[Any]