Skip to content

Commit

Permalink
- [ios] remove prose plugin
Browse files Browse the repository at this point in the history
  • Loading branch information
cxfeng1 committed Jan 17, 2017
1 parent 8df0632 commit c43f792
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
language: objective-c
rvm: 2.0.0
before_install:
- gem install danger danger-xcode_summary danger-prose xcpretty xcpretty-json-formatter
- gem install danger danger-xcode_summary xcpretty xcpretty-json-formatter
script:
- xcodebuild -project ios/sdk/WeexSDK.xcodeproj test -scheme WeexSDKTests CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO -destination 'platform=iOS Simulator,name=iPhone 6' | XCPRETTY_JSON_FILE_OUTPUT=ios/sdk/xcodebuild.json xcpretty -f `xcpretty-json-formatter`
- bundle exec danger
8 changes: 6 additions & 2 deletions Dangerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@ warn("Big PR") if git.lines_of_code > 500
xcode_summary.ignored_files = '**/Pods/**'
xcode_summary.report 'ios/sdk/xcodebuild.json'

prose.check_spelling "ios/sdk/**/*.h"
prose.check_spelling "ios/sdk/**/*.m"

# oc_files = (git.modified_files + git.added_files).select do |line|
line.end_with?(".h") || line.end_with?(".m") || line.end_with?(".mm")
end

# prose.check_spelling oc_files

# Find reviewers without parsing blame information
# from files matching to 'Pods/*'
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ gem "xcpretty"
gem "xcpretty-json-formatter"
gem "danger"
gem "danger-xcode_summary"
gem "danger-prose"

# gem "danger-prose"
# gem "danger-clorox"
# gem "danger-mention"

Expand Down
3 changes: 0 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ GEM
terminal-table (~> 1)
danger-plugin-api (1.0.0)
danger (> 2.0)
danger-prose (2.0.3)
danger
danger-xcode_summary (0.1.0)
danger-plugin-api (~> 1.0)
faraday (0.11.0)
Expand Down Expand Up @@ -57,7 +55,6 @@ PLATFORMS

DEPENDENCIES
danger
danger-prose
danger-xcode_summary
xcpretty
xcpretty-json-formatter
Expand Down

0 comments on commit c43f792

Please sign in to comment.