-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] basic "test all estimators" suite #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 71.67% 71.63% -0.05%
==========================================
Files 93 97 +4
Lines 4950 5157 +207
Branches 900 952 +52
==========================================
+ Hits 3548 3694 +146
- Misses 1173 1206 +33
- Partials 229 257 +28
☔ View full report in Codecov by Sentry. |
fkiraly
added
the
module:tests
test framework functionality - only framework, excl specific tests
label
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
TestAllEstimators
which checks generic fit/predict capabilities of estimators.This is partly migrated from
sktime
, and uses thescikit-base
test framework classes (also originally fromsktime
).This can also be used as a joint refactor point with
sktime
andskbase
.Additions and changes:
TestAllEstimators
classBaseFixtureGenerator
which generatesscenarios
. For this, theskpro
fixture generator now inherits fromskbase
.skbase
yet, so thesktime
scenario framework is copied totests.scenarios
.