Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix plot_crossplot_std for predict_var return #71

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Sep 10, 2023

This PR fixes an unreported bug where plot_crossplot_std would crash for for a predict_var return (as opposed to a full distributional prediction).

This is fixed, and a test is added.

@fkiraly fkiraly added bug module:regression probabilistic regression module labels Sep 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (54a73a1) 71.35% compared to head (3acc465) 71.39%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   71.35%   71.39%   +0.03%     
==========================================
  Files          92       92              
  Lines        4940     4943       +3     
  Branches      897      897              
==========================================
+ Hits         3525     3529       +4     
  Misses       1179     1179              
+ Partials      236      235       -1     
Files Changed Coverage Δ
skpro/utils/plotting.py 94.73% <100.00%> (+1.87%) ⬆️
skpro/utils/tests/test_plots.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit 5e855e0 into main Sep 10, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug module:regression probabilistic regression module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants