Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] in ResidualDouble, fix out-of-sample residual prediction if residual estimator is default #70

Merged
merged 1 commit into from
Sep 10, 2023
Merged

[BUG] in ResidualDouble, fix out-of-sample residual prediction if residual estimator is default #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions skpro/regression/residual.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def _predict_residuals_cv(self, X, y, cv, est):
y_pred : pandas DataFrame, same length as `X`, same columns as `y` in `fit`
labels predicted for `X`
"""
est = self.estimator_resid
est = self.estimator_resid_
method = "predict"
y_pred = y.copy()

Expand Down Expand Up @@ -382,5 +382,6 @@ def get_test_params(cls, parameter_set="default"):
"distr_params": {"df": 3},
"cv": KFold(n_splits=3),
}
params4 = {"estimator": RandomForestRegressor(), "cv": KFold(n_splits=3)}

return [params1, params2, params3]
return [params1, params2, params3, params4]
Loading