Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] remove legacy model_selection module #58

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Sep 8, 2023

This PR removes the legacy regression.model_selection module.

The functionality therein is now replaced by the benchmarking and model_selection modules.

@fkiraly fkiraly added maintenance Continuous integration, unit testing & package distribution module:regression probabilistic regression module labels Sep 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.29% 🎉

Comparison is base (0d8bd68) 70.91% compared to head (fac4c28) 71.21%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   70.91%   71.21%   +0.29%     
==========================================
  Files          93       92       -1     
  Lines        4962     4933      -29     
  Branches      900      896       -4     
==========================================
- Hits         3519     3513       -6     
+ Misses       1205     1182      -23     
  Partials      238      238              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit 3d8f312 into main Sep 10, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution module:regression probabilistic regression module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants