Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] registry module with lookup and tag register #44

Merged
merged 11 commits into from
Aug 26, 2023
Merged

[ENH] registry module with lookup and tag register #44

merged 11 commits into from
Aug 26, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Aug 26, 2023

This PR adds a registry module, with lookup and tag register.

Contents:

  • a tag register in registry._tags. The current register from test_all_estimators is migrated there.
  • a _lookup module with all_objects and all_tags lookup methods, as in sktime.
  • populates object_type tag for all objects in skpro

In contrast to sktime, no base class registry is added, as this is now handled via the tag system and the object_type tag.

@fkiraly fkiraly added enhancement module:base-framework BaseObject, registry, base framework labels Aug 26, 2023
@fkiraly fkiraly merged commit 47a1b19 into main Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement module:base-framework BaseObject, registry, base framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant