Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Uniform Continuous distribution #223

Merged
merged 10 commits into from
Apr 25, 2024
Merged

[ENH] Uniform Continuous distribution #223

merged 10 commits into from
Apr 25, 2024

Conversation

an20805
Copy link
Contributor

@an20805 an20805 commented Mar 25, 2024

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Implemented Uniform Continuous Probability Distribution, towards #22

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Testing the distribution

Did you add any tests for the change?

No

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@fkiraly fkiraly added enhancement module:probability&simulation probability distributions and simulators implementing algorithms Implementing algorithms, estimators, objects native to skpro labels Mar 25, 2024
@fkiraly
Copy link
Collaborator

fkiraly commented Mar 25, 2024

you said you had some questions in 22 - what do you need help with?

@an20805
Copy link
Contributor Author

an20805 commented Mar 25, 2024

Its showing Read the Docs build failed. How can it be solved?

@fkiraly
Copy link
Collaborator

fkiraly commented Mar 25, 2024

Its showing Read the Docs build failed. How can it be solved?

That look new - a syntax error in one of the json files related to docs.

@fkiraly
Copy link
Collaborator

fkiraly commented Mar 25, 2024

I am suspecting switcher.json, but why would that start breaking now?

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to new interface contract introduced in #265

@fkiraly
Copy link
Collaborator

fkiraly commented Apr 25, 2024

failures are due to bugs fixed in #281, that should be merged first and tests re-run

@fkiraly fkiraly merged commit 4e7d7f1 into sktime:main Apr 25, 2024
26 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement implementing algorithms Implementing algorithms, estimators, objects native to skpro module:probability&simulation probability distributions and simulators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants