Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] n_features and feature_names metadata field for table mtypes #150

Merged
merged 9 commits into from
Dec 25, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Dec 2, 2023

This PR adds n_features and feature_names metadat field for data table mtypes - similar to the attributes of the same name in sklearn.

This will be useful for cleaner input/output queriability in a variety of places, and further sklearn compatibility.

Similar to sktime/sktime#5596 (for time series)

@fkiraly fkiraly added the module:datatypes datatypes module: data containers, checkers & converters label Dec 2, 2023
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ffbde52) 64.09% compared to head (5948f3d) 64.27%.
Report is 1 commits behind head on main.

Files Patch % Lines
skpro/datatypes/_table/_check.py 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   64.09%   64.27%   +0.18%     
==========================================
  Files         104      104              
  Lines        5534     5568      +34     
  Branches     1022     1040      +18     
==========================================
+ Hits         3547     3579      +32     
- Misses       1705     1706       +1     
- Partials      282      283       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit f6f29d9 into main Dec 25, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:datatypes datatypes module: data containers, checkers & converters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant