use correct reader schema in AvroBinaryInputStream #817
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
My coworker @maxstreese recently tried backward compatibility using avro4s, but it didn't work out. Here's his code:
Clearly this should work because removed fields don't affect backward compatibility and there is a default for the new field
c
. But it doesn't work becauseAvroBinaryInputStream
doesn't supply the reader schema to the decoder.This PR adds a new constructor for
AvroBinaryInputStream
that allows supplying a reader schema.I also got rid of one of those ugly
asInstanceOf
calls while I was at it.Here are some related issues that this PR doesn't fix:
AvroInputStream
object because that would break binary compatibilityAvroDataInputStream
is probably suffering the same issue