Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the StringEncoder transformer #1159
base: main
Are you sure you want to change the base?
Adding the StringEncoder transformer #1159
Changes from 33 commits
ec37e13
b3dae47
99e5450
4f7e46e
583250b
4a39f36
ee2f739
30ad689
d7f1cd7
8686d7f
eb4de97
96423ba
e01637c
3a1f6eb
398f9db
3a45f19
38a9f2d
51856b3
58a3559
8e4fce2
afdb361
6c6d884
9366d90
6b474c6
e8f308e
8ea92d8
c999abf
8411a83
190ce2a
a43488e
cdfaf1a
c0c066f
887e047
af3b087
2bb353d
bfb8c55
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't the tfidf vectorizer and truncated svd do a similar validation already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left in only the first check, the other constraints are in there, but I think they're less strict