Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluralize the :topic initialization option #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Pluralize the :topic initialization option #17

wants to merge 4 commits into from

Commits on Apr 18, 2019

  1. Pluralize the :topic initialization option 

    By default, kafka and kafka-go support consumers subscribing to
multiple topics, by passing an array of strings.

Rafka also respects this (see server.go#parseTopicsAndConfig).

Rafka-rb simply needs to change the wording in order to respect
the plural and in effect show the api user that consuming from
multiple topics is supported.

The commit takes the extra step of supporting an array of strings
as well as a single string, whether it contains a single topic or
multiple comma-separated topics.

Closes #5
    @fragoulis
    fragoulis committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    78ae428 View commit details
    Browse the repository at this point in the history

  2. fixup! Pluralize the :topic initialization option

    @fragoulis
    fragoulis committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    c2c04d8 View commit details
    Browse the repository at this point in the history

  3. fixup! Pluralize the :topic initialization option

    @fragoulis
    fragoulis committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    3ed904e View commit details
    Browse the repository at this point in the history

  4. fixup! Pluralize the :topic initialization option

    @fragoulis
    fragoulis committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    c51626e View commit details
    Browse the repository at this point in the history