Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move avg hash to card & add eff avg #643

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mrv777
Copy link
Contributor

@mrv777 mrv777 commented Jan 11, 2025

Description

  • Move the average hashrate from the chart to the card
  • Add average efficiency
    • Needed to add array to record power since it can change and is needed for this
  • Removed unused variable & don't let temperatureData go over 720 data points too
image

Issue reference: #633

@mrv777
Copy link
Contributor Author

mrv777 commented Jan 11, 2025

Only thing I don't like is how long the text gets with expected on that same line. I didn't want to do a new line though as there is that imbalance in my eyes unless we had more data to the last 2 cards too so they all have 4 lines

@mrv777
Copy link
Contributor Author

mrv777 commented Jan 11, 2025

I think this may be better
image

@mutatrum
Copy link
Contributor

Maybe add expected on the bottom line, next to average, right aligned in the card?

@mrv777
Copy link
Contributor Author

mrv777 commented Jan 12, 2025

Maybe add expected on the bottom line, next to average, right aligned in the card?

Have to figure out if that looks okay on smaller screens too

@mutatrum
Copy link
Contributor

If it gets smaller, all values of a card should be on their own line, I would think?

@mrv777
Copy link
Contributor Author

mrv777 commented Jan 16, 2025

Maybe this is better?
image

@mrv777
Copy link
Contributor Author

mrv777 commented Jan 16, 2025

or this
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants