wip: ODS-xxxx expose dashboard 8080 and curl to it #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It runs... |
jiridanek
commented
Jan 10, 2024
| static final Logger LOGGER = LoggerFactory.getLogger(DataScienceDashboardST.class); | ||
|
|
||
| @Test | ||
| void checkDataScienceProjects() throws IOException, InterruptedException { |
There was a problem hiding this comment.
@Tag("ODS-1860")?
jiridanek
commented
Jan 10, 2024
Comment on lines
+111
to
+112
| service.edit().editSpec().removeFromPorts(port1, port2).endSpec().build(); | ||
| kubeClient.routes().resource(route).delete(); |
jiridanek
commented
Jan 10, 2024
| LOGGER.debug("Making request {}", request); | ||
| HttpClient httpClient = HttpClient.newHttpClient(); | ||
| HttpResponse<Void> response = httpClient.send(request, HttpResponse.BodyHandlers.discarding()); | ||
| LOGGER.debug("Got response {}", response); |
There was a problem hiding this comment.
Regarding the test scenario itself. Maybe run this curl directly in the container the service is fronting? Or put my own container that contains curl there, and don't expose any routes...?
jiridanek
force-pushed
the
jd_ods-1860
branch
from
19fe509 to
d67ac1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oc patch -n redhat-ods-applications service rhods-dashboard -p '{"spec": {"ports": [{"name": "8443-tcp", "protocol": "TCP", "port": 8443, "targetPort": 8443}]}}'
oc patch -n redhat-ods-applications service rhods-dashboard -p '{"spec": {"ports": [{"name": "8080-tcp", "protocol": "TCP", "port": 8080, "targetPort": 8080}]}}'
We can see the service conf with this command:
oc get -n redhat-ods-applications service rhods-dashboard -o json
oc apply -f rhods-dashboard-internal-route.yaml
apiVersion: route.openshift.io/v1
kind: Route
metadata:
name: rhods-dashboard-internal
namespace: redhat-ods-applications
labels:
app: rhods-dashboard
app.kubernetes.io/part-of: rhods-dashboard
spec:
port:
targetPort: 8080-tcp
to:
kind: Service
name: rhods-dashboard
wildcardPolicy: None
curl --location --request GET 'http://rhods-dashboard-internal-redhat-ods-applications.apps.{cluster_name}.xxx.com/api/status' --header 'x-forwarded-access-token: asdfadsfasd'
Verify response status code is error 401, similar to this:
{"statusCode":401,"code":"401","error":"Unauthorized","message":"Failed to retrieve username: Error getting Oauth Info for user, Unauthorized"}
Note: in RHODS 1.18 and before, the response was error 500, provoking alert RHODS Dashboard Route Error to fire
{"statusCode":500,"code":"500","error":"Internal Server Error","message":"Failed to retrieve username: Error getting Oauth Info for user, undefined - HTTP request failed"}
oc delete route rhods-dashboard-internal -n redhat-ods-applications