ISSUE-160: fix(test/utils): migrate from java.util.Date to java.time.Instant to resolve fabric8 crash
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me.Instant` to resolve fabric8 crash Instants are the recommended way to deal with time and date in Java 8+. The problem was caused by the wrongly encoded `+` in the timestamp string when it's a part of a URL. Because Instants represent time in UTC timezone (`Z`), we don't get the timezone part of timestamp now (`+02:00`), so there's no plus problem.
kornys
approved these changes
Oct 17, 2024
Frawless
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instants are the recommended way to deal with time and date in Java 8+.
The problem was caused by the wrongly encoded
+in the timestamp string when it's a part of a URL. Because Instants represent time in UTC timezone (Z), we don't get the timezone part of timestamp now (+02:00), so there's no plus problem.Fixes #160