Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PipelineV2ServerST test #113

Merged
merged 12 commits into from
Mar 21, 2024
Merged

Conversation

jiridanek
Copy link
Collaborator

UI does not work for me; there are various config snippets around which use different images for the pipelines ui thing, such as https://github.com/opendatahub-io/data-science-pipelines-operator/blob/eb6fe1401f90514c07138421831aae8298aa9ee2/config/samples/v2/local-dev/dspa.yaml and what jorge has in googledoc.

Could not figure out the random 5char string that Argo Workflow pods get. I need to find it from somewhere.

Pipeline to run is from jorge. I did not manage to compile my own (was getting import error on pandas).

@jiridanek
Copy link
Collaborator Author

jiridanek commented Mar 4, 2024

Error: /home/runner/work/odh-e2e/odh-e2e/src/test/java/io/odh/test/e2e/standard/PipelineV2ServerST.java:77:1: Class Fan-Out Complexity is 47 (max allowed is 44). [ClassFanOutComplexity]

Error: /home/runner/work/odh-e2e/odh-e2e/src/test/java/io/odh/test/e2e/standard/PipelineV2ServerST.java:168:5: Method testUserCanCreateRunAndDeleteADSPipelineFromDSProject length is 163 lines (max allowed is 150). [MethodLength]

😢

@kornys
Copy link
Member

kornys commented Mar 4, 2024

Error: /home/runner/work/odh-e2e/odh-e2e/src/test/java/io/odh/test/e2e/standard/PipelineV2ServerST.java:77:1: Class Fan-Out Complexity is 47 (max allowed is 44). [ClassFanOutComplexity]

Error: /home/runner/work/odh-e2e/odh-e2e/src/test/java/io/odh/test/e2e/standard/PipelineV2ServerST.java:168:5: Method testUserCanCreateRunAndDeleteADSPipelineFromDSProject length is 163 lines (max allowed is 150). [MethodLength]

😢

just update requirements to allow more complexity
line length issue is simple to fix

@jiridanek jiridanek marked this pull request as ready for review March 20, 2024 17:40
Copy link
Member

@kornys kornys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@jiridanek jiridanek enabled auto-merge (squash) March 21, 2024 08:13
@jiridanek jiridanek merged commit 7f54ad8 into skodjob:main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants