Address comments v1

Signed-off-by: David Kornel <[email protected]>
skodjob · May 7, 2024 · 181c323 · 181c323
1 parent 4e1e7f5
commit 181c323
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/src/main/java/io/odh/test/framework/manager/resources/DataScienceClusterResource.java b/src/main/java/io/odh/test/framework/manager/resources/DataScienceClusterResource.java
@@ -132,8 +132,7 @@ public boolean waitForReadiness(DataScienceCluster resource) {
             // https://github.com/red-hat-data-services/rhods-operator/blob/rhoai-2.8/controllers/datasciencecluster/datasciencecluster_controller.go#L257
 
             // Wait for standard Kubernetes condition types (status for the whole DSC)
-            record ConditionExpectation(String conditionType, String expectedStatus) {
-            }
+            record ConditionExpectation(String conditionType, String expectedStatus) { }
             List<ConditionExpectation> conditionExpectations = List.of(
                     new ConditionExpectation("Available", "True"),
                     new ConditionExpectation("Progressing", "False"),
@@ -165,8 +164,7 @@ record ConditionExpectation(String conditionType, String expectedStatus) {
             dscReady = dscReady && hasCreationSuccessfulEvent;
 
             return dscReady;
-        }, () -> {
-        });
+        }, () -> { });
 
         String namespace = OdhConstants.CONTROLLERS_NAMESPACE;
         LOGGER.info("Waiting for pods readiness in {}", namespace);

diff --git a/src/test/java/io/odh/test/e2e/continuous/DataScienceClusterST.java b/src/test/java/io/odh/test/e2e/continuous/DataScienceClusterST.java
@@ -25,7 +25,6 @@
 import io.opendatahub.datasciencecluster.v1.datascienceclusterspec.components.Ray;
 import io.opendatahub.datasciencecluster.v1.datascienceclusterspec.components.Workbenches;
 import io.opendatahub.v1alpha.OdhDashboardConfig;
-import io.skodjob.testframe.annotations.ResourceManager;
 import io.skodjob.testframe.resources.KubeResourceManager;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Tag;
@@ -39,7 +38,6 @@
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 @Tag(TestSuite.CONTINUOUS)
-@ResourceManager(cleanResources = false)
 public class DataScienceClusterST extends Abstract {
 
     private static final String DS_CLUSTER_NAME = "default";

diff --git a/src/test/java/io/odh/test/e2e/continuous/DataScienceProjectST.java b/src/test/java/io/odh/test/e2e/continuous/DataScienceProjectST.java
@@ -11,7 +11,6 @@
 import io.odh.test.TestUtils;
 import io.odh.test.e2e.Abstract;
 import io.odh.test.framework.manager.resources.NotebookResource;
-import io.skodjob.testframe.annotations.ResourceManager;
 import io.skodjob.testframe.resources.KubeResourceManager;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Tag;
@@ -28,7 +27,6 @@
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 @Tag(TestSuite.CONTINUOUS)
-@ResourceManager(cleanResources = false)
 public class DataScienceProjectST extends Abstract {
     static final Logger LOGGER = LoggerFactory.getLogger(DataScienceProjectST.class);