Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some comments #834

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some comments #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion abci/strategies/aggregator/price_applier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type PriceApplier interface {
// otherwise an error is returned + nil prices.
ApplyPricesFromVoteExtensions(ctx sdk.Context, req *cometabci.RequestFinalizeBlock) (map[connecttypes.CurrencyPair]*big.Int, error)

// GetPriceForValidator gets the prices reported by a given validator. This method depends
// GetPricesForValidator gets the prices reported by a given validator. This method depends
// on the prices from the latest set of aggregated votes.
GetPricesForValidator(validator sdk.ConsAddress) map[connecttypes.CurrencyPair]*big.Int
}
Expand Down
2 changes: 1 addition & 1 deletion providers/base/provider_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ func TestWebSocketProvider(t *testing.T) {
expectedPrices: map[connecttypes.CurrencyPair]*big.Int{},
},
{
name: "updates the timestamp associated with a result if the the data is unchanged and still valid",
name: "updates the timestamp associated with a result if the data is unchanged and still valid",
handler: func() wshandlers.WebSocketQueryHandler[connecttypes.CurrencyPair, *big.Int] {
// First response is valid and sets the data.
resolved := map[connecttypes.CurrencyPair]providertypes.ResolvedResult[*big.Int]{
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/connect_suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ func (s *ConnectOracleIntegrationSuite) TestOracleModule() {
s.Run("remove a non existent market", func() {
nonexistentCP := connecttypes.NewCurrencyPair("NON", "EXIST")

// check removed doesnt exist
// check removed doesn't exist
_, err := QueryMarket(s.chain, nonexistentCP)
s.Require().Error(err)

Expand Down