Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kernel fix to 6.8 #320

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Remove kernel fix to 6.8 #320

merged 2 commits into from
Sep 30, 2024

Conversation

maxberger
Copy link
Contributor

This causes build failures when trying to build a 6.10 kernel

This causes build failures when trying to build a 6.10 kernel

Signed-off-by: Max Berger <[email protected]>
@@ -9,7 +9,6 @@ BR2_LINUX_KERNEL_NEEDS_HOST_LIBELF=y
# see: https://kernel.org
BR2_LINUX_KERNEL_CUSTOM_VERSION=y
BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.10.7"
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_8=y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you set this to 6_10 here and/or override it wherever needed?

I remember there was some reason for setting it here, I believe it's because when buildroot is updated and a newer version becomes available, things will break unless we pin the headers version here. But this may not be the case anymore, let me know if so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this line my build failed, becasuse buildroot expected 6.8 kernel headers, and got 6.10 kernel headers instead. So this is probably only needed if the kernel version is overwritten. But that would need to be tested.

@paralin paralin changed the base branch from master to dev September 30, 2024 07:34
@paralin paralin merged commit 48786cb into skiffos:dev Sep 30, 2024
@paralin
Copy link
Collaborator

paralin commented Oct 9, 2024

INSTALL /home/cjs.linux/repos/skiff-configs/skiff/workspaces/desktop/host/x86_64-buildroot-linux-uclibc/sysroot/usr/include
if ! support/scripts/check-kernel-headers.sh /home/cjs.linux/repos/skiff-configs/skiff/workspaces/desktop/build /home/cjs.linux/repos/skiff-configs/skiff/workspaces/desktop/host/x86_64-buildroot-linux-uclibc/sysroot 2.6 strict; then exit 1; fi
Incorrect selection of kernel headers: expected 2.6.x, got 6.11.x

For whatever reason this happens when building x86, so I think we need the line selecting the latest kernel headers revision.

@maxberger
Copy link
Contributor Author

INSTALL /home/cjs.linux/repos/skiff-configs/skiff/workspaces/desktop/host/x86_64-buildroot-linux-uclibc/sysroot/usr/include
if ! support/scripts/check-kernel-headers.sh /home/cjs.linux/repos/skiff-configs/skiff/workspaces/desktop/build /home/cjs.linux/repos/skiff-configs/skiff/workspaces/desktop/host/x86_64-buildroot-linux-uclibc/sysroot 2.6 strict; then exit 1; fi
Incorrect selection of kernel headers: expected 2.6.x, got 6.11.x

For whatever reason this happens when building x86, so I think we need the line selecting the latest kernel headers revision.

Interesting. In my case the Error Message was the Same, but the other way round.

But why does x86 need kernel 2.6 Headers? That seems quite outdated.

-> If we need this line, so bei it. But it should probably always reflect the current kernel Version (at the time it said 6_8 but kernel was 6.10)

@paralin
Copy link
Collaborator

paralin commented Oct 9, 2024

The line, if you check menu config, says "Kernel version 6.10.x or newer"

Unfortunately there isn't a "latest" option as far as I see, so I'm just setting it to the most recent (highest) one.

@paralin
Copy link
Collaborator

paralin commented Oct 9, 2024

If you have that error, wherever you configure the kernel version, also need to set the kernel headers major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants