Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track resources as a git submodule #22

Conversation

trusktr
Copy link

@trusktr trusktr commented Apr 25, 2024

Along with

this helps to make the project fully reproducible at any commit. This is simpler and better than manually cloning the asset repo because it will always get the commit that is known to work, and doesn't require having to memorize where to clone.

As an example of why this is important, if you try the current main branch, and clone the res repo to examples/_res, some example will be broken, and the user will not know which commit to check out.

Closes #13

trusktr added 2 commits April 24, 2024 17:19
…abylon and undo the TODO checkbox as Babylon is not currently supported in ossos_next
@trusktr
Copy link
Author

trusktr commented Apr 25, 2024

Closes #13

@trusktr
Copy link
Author

trusktr commented Apr 25, 2024

I'm still getting

http://localhost:3010/prototypes/_res/models/fortman/fortnite_mann.gltf 404 (Not Found)

in prototypes/armature/005_apose_tpose.html

Is the commit for res repo wrong? Or are you writing these example with private files on your local filesystem? If the latter, it would be so much better if you could push them to res so others like me can reproduce.

EDIT: I'm getting a lot of 404s in other pages too. Can you please push an update to res? Or, are those examples just not updated to the new system yet?

@trusktr trusktr closed this Apr 25, 2024
@trusktr trusktr deleted the joe/resources-as-git-submodule branch April 25, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant