Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FloatingArrow component #35

Merged
merged 32 commits into from
May 6, 2024
Merged

Add FloatingArrow component #35

merged 32 commits into from
May 6, 2024

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented May 1, 2024 •
edited
Loading

Closes #9

Todo

@endigo9740 endigo9740 linked an issue May 1, 2024 that may be closed by this pull request
Add: FloatingArrow component #9
Closed
12 tasks
@vercel Vercel
Copy link

vercel bot commented May 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
floating-ui-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 7:20pm

@endigo9740 endigo9740 marked this pull request as draft May 1, 2024 21:46
@endigo9740 endigo9740 requested a review from Hugos68 May 3, 2024 21:27
@endigo9740 endigo9740 marked this pull request as ready for review May 3, 2024 21:27
@Hugos68

This comment was marked as resolved.

Sign in to view
Hugos68
Hugos68 requested changes May 4, 2024
View reviewed changes
Copy link
Collaborator

@Hugos68 Hugos68 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done my review. Only saw 1 real problem with ..rest which needed a change on multiple places, hence the amount of comments. Apart from that you've done an amazing job. I'm really excited to be able to use this component!

README.md Show resolved Hide resolved
src/lib/components/FloatingArrow/types.ts Outdated Show resolved Hide resolved
src/lib/components/FloatingArrow/types.ts Show resolved Hide resolved
src/lib/components/FloatingArrow/FloatingArrow.svelte Show resolved Hide resolved
src/lib/components/FloatingArrow/FloatingArrow.svelte Outdated Show resolved Hide resolved
src/lib/components/FloatingArrow/FloatingArrow.svelte Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@endigo9740 endigo9740 requested a review from Hugos68 May 6, 2024 19:37
Hugos68
Hugos68 approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@Hugos68 Hugos68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@endigo9740 endigo9740 merged commit 5cd74c9 into dev May 6, 2024
7 checks passed
@endigo9740 endigo9740 deleted the feature/floating-arrow-component branch May 6, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hugos68 Hugos68 Hugos68 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add: FloatingArrow component
2 participants
@endigo9740 @Hugos68