Add missing optparse_long_only() and useful macros for Windows, also separate definition and implementation. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeeeeeeelias
changed the title
eeeeeeeelias
changed the title
ShamrockLee
suggested changes
Dec 31, 2021
| @@ -44,20 +44,28 @@ | |||
| * arguments to the end. This can be disabled by setting the `permute` | |||
| * field to 0 after initialization. | |||
| */ | |||
|
|
|||
| #ifndef OPTPARSE_IMPLEMENTATION | |||
There was a problem hiding this comment.
It doesn't make sense to exclude function declarations and macro definitions when implementation is asked for.
AFAIK, forward declaration is a good practice when writing C. It not only guarentees the consistency between the header and the implementation, but also enables calling another function defined below the current one.
| #define TCHAR char | ||
| #define _TEXT(x) x | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Are TCHAR and TEXT() macros still relevent? Could TCHAR be converted to int implicitly?
I'm not familiar with Windows. Please feal free to correct me.
https://docs.microsoft.com/en-us/windows/win32/learnwin32/working-with-strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.