Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Fix banner top swipe in old docs #3579

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

chore(docs): Fix banner top swipe in old docs #3579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
349edf5
chore(docs): prevent scrollTop in styleguide
sashachabin Dec 24, 2024
fdfff1d
chore(docs): increase notification banner z-index
sashachabin Dec 24, 2024
2cd4f72
chore(docs): replace overscrollBehavior to overscrollBehaviorY
sashachabin Dec 24, 2024
e2b9c32
Merge branch 'next' into fix-banner-top-scroll
sashachabin Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-ui-validations/docs/Common/Notification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import styled from 'styled-components';

export const NotificationContainer = styled.div`
position: sticky;
z-index: 2;
z-index: 10;
top: 0;
left: 0;
display: flex;
Expand Down
1 change: 1 addition & 0 deletions packages/react-ui-validations/docs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { Validator } from './Pages/Validator';
import { Concepts } from './Pages/Concepts';

import 'docs/styles/reset.less';
import 'docs/styles/main.less';
import 'docs/styles/typography.less';

const App = hot(() => (
Expand Down
3 changes: 3 additions & 0 deletions packages/react-ui-validations/docs/styles/main.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
body {
overscroll-behavior-y: none;
}
2 changes: 1 addition & 1 deletion packages/react-ui/.styleguide/components/Notification/Notification.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export const styles = memoizeStyle({
notification() {
return css`
position: sticky;
z-index: 2;
z-index: 10;
top: 0;
left: 0;
display: flex;
Expand Down
1 change: 1 addition & 0 deletions packages/react-ui/.styleguide/components/StyleGuideWrapper/StyleGuideWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ function StyleGuideRenderer({ children, hasSidebar, toc, title, version }: Style
const [theme, setTheme] = useState(DEFAULT_THEME_WRAPPER);
document.body.style.fontFamily = 'Lab Grotesque, Roboto, Helvetica Neue, Arial, sans-serif';
document.body.style.fontSize = '14px';
document.body.style.overscrollBehaviorY = 'none';

const isThemeDark = theme.toLowerCase().includes('dark');

Expand Down