Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Добавить data-tid #2900

Merged
merged 43 commits into from
Jun 28, 2022
Merged

Добавить data-tid #2900

merged 43 commits into from
Jun 28, 2022

Conversation

HelenaIsh
Copy link
Contributor

@HelenaIsh HelenaIsh commented May 26, 2022 •
edited
Loading

IF-507

Данный ПР добавляет публичным компонентам атрибут data-tid.
Также добавлен экспорт data-tid'ов по просьбе из слака.
В доках создала страничку, где можно посмотреть data-tid для всех компонентов.

@HelenaIsh HelenaIsh requested a review from JackUait May 31, 2022 08:44
@HelenaIsh HelenaIsh marked this pull request as ready for review May 31, 2022 08:44
JackUait
JackUait suggested changes May 31, 2022
View reviewed changes
packages/react-ui/lib/data-tid/DATATID.md Outdated Show resolved Hide resolved
packages/react-ui/lib/data-tid/DATATID.md Outdated Show resolved Hide resolved
packages/react-ui/lib/data-tid/componentsDataTid.ts Outdated Show resolved Hide resolved
packages/react-ui/lib/data-tid/componentsDataTid.ts Outdated Show resolved Hide resolved
packages/react-ui/components/DatePicker/Picker.tsx Outdated Show resolved Hide resolved
zhzz
zhzz reviewed Jun 1, 2022
View reviewed changes
packages/react-ui/lib/data-tid/DATATID.md Outdated Show resolved Hide resolved
packages/react-ui/components/Button/Button.tsx Outdated Show resolved Hide resolved
packages/react-ui/lib/data-tid/DataTid.tsx Outdated Show resolved Hide resolved
@HelenaIsh HelenaIsh marked this pull request as draft June 1, 2022 12:16
@JackUait
Copy link
Contributor

JackUait commented Jun 2, 2022

В копилку улучшения UX для доки: Select'у с компонентами стоит добавить поиск

@lossir lossir mentioned this pull request Jun 9, 2022
Draft
JackUait
JackUait previously approved these changes Jun 10, 2022
View reviewed changes
@HelenaIsh HelenaIsh requested a review from lossir June 14, 2022 05:17
@HelenaIsh HelenaIsh requested review from lossir and JackUait June 15, 2022 13:21
@zhzz zhzz removed their request for review June 17, 2022 12:05
JackUait
JackUait previously approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@JackUait JackUait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По моим комментам - всё. Максим (@lossir), глянь пожалуйста, можем ли мы вливать изменения

lossir
lossir previously approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@lossir lossir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Всё ок=) Осталось кофликт порешать, чтобы влить

packages/react-ui/internal/PopupMenu/PopupMenu.tsx Outdated Show resolved Hide resolved
@HelenaIsh HelenaIsh dismissed stale reviews from lossir and JackUait via 74e6fa3 June 27, 2022 11:53
@HelenaIsh HelenaIsh requested review from lossir and JackUait June 28, 2022 04:27
@lossir lossir merged commit 627e841 into master Jun 28, 2022
@lossir lossir deleted the data-tid branch June 28, 2022 11:52
This was referenced Feb 6, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhzz zhzz zhzz left review comments

@JackUait JackUait JackUait approved these changes

@lossir lossir lossir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HelenaIsh @JackUait @lossir @zhzz