Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kompatibilita s PHP 7.2 #20

Merged
merged 5 commits into from
Apr 4, 2018
Merged

Kompatibilita s PHP 7.2 #20

merged 5 commits into from
Apr 4, 2018

Conversation

fmasa
Copy link
Member

@fmasa fmasa commented Mar 26, 2018

No description provided.

@sinacek sinacek requested a review from xificurk March 26, 2018 18:12
@fmasa fmasa force-pushed the php7.2-compatibility branch from 7e65f7f to 141786e Compare March 27, 2018 07:23
@xificurk
Copy link
Contributor

Tohle reálně znamená dropnutí podpory pro Nette <2.4, tzn. bude potřeba bumpnout minimální verze composer.json, odstranit testy proti starším verzím Nette a odstranit kód, který zajišťoval kompatibilitu mezi všemi verzemi Nette (lze se inspirovat, příp. cherry-pickovat z #17 ).

@fmasa
Copy link
Member Author

fmasa commented Mar 27, 2018

Spíše dropnutí nette/utils < 2.4 a Nette 2.1. Ostatní komponenty (nette/di) lze dál používat ve starších verzích. I když Nette drží spíše pseudo-BC.

@fmasa
Copy link
Member Author

fmasa commented Mar 27, 2018 •
edited
Loading

Ale jsem pro drop nižších verzí 👍

@fmasa fmasa force-pushed the php7.2-compatibility branch from dd316b9 to af1c3e7 Compare March 27, 2018 08:47
@fmasa fmasa force-pushed the php7.2-compatibility branch from af1c3e7 to 83e814b Compare March 27, 2018 09:01
@fmasa
Copy link
Member Author

fmasa commented Mar 27, 2018

Rebasnuto, @xificurk můžeš na to mrknout?

@fmasa
Copy link
Member Author

fmasa commented Apr 3, 2018

@xificurk Můžeš mrknout a případně mergnout?

xificurk
xificurk requested changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@xificurk xificurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skvělá práce, jen prosím ještě dvě drobnosti.

src/Tracy/Panel.php Outdated
@@ -54,7 +33,7 @@ public function register(WsdlManager $wsdlManager)
{
$wsdlManager->addWebServiceListener(WebService::EVENT_SUCCESS, array($this, 'logEvent'));
$wsdlManager->addWebServiceListener(WebService::EVENT_FAILURE, array($this, 'logEvent'));
call_user_func(array($this->debuggerClass, 'getBar'))->addPanel($this);
call_user_func([Tracy\Debugger::class, 'getBar'])->addPanel($this);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Použij tu prosím přímé volání statické metody místo call_user_func

src/Tracy/Panel.php Outdated
@@ -136,7 +115,7 @@ protected function prepareTrace(array $trace)
*/
protected function dump($object)
{
return call_user_func(array($this->debuggerClass, 'dump'), $object, TRUE);
return call_user_func([Tracy\Debugger::class, 'dump'], $object, TRUE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Použij tu prosím přímé volání statické metody místo call_user_func

@fmasa
Copy link
Member Author

fmasa commented Apr 4, 2018

@xificurk Upravil jsem

@xificurk xificurk merged commit 0a4faca into skaut:2.x Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xificurk xificurk xificurk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmasa @xificurk