Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1963 fix max fee per gas in json rpc representation #1985

Merged
merged 2 commits into from
Sep 11, 2024
Merged

#1963 fix max fee per gas in json rpc representation #1985

merged 2 commits into from
Sep 11, 2024

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Sep 10, 2024 •
edited
Loading

fixes #1963
fixed the typo that prevented skaled to show the correct value of maxFeePerGas for type2 txns

fixed unittets to handle this issue

no performance impact

before fix

maxFeePerGas: 0
maxPriorityFeePerGas: 0

after fix

maxFeePerGas: 100000
maxPriorityFeePerGas: 0

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@olehnikolaiev olehnikolaiev merged commit 070d3a2 into develop Sep 11, 2024
6 checks passed
@olehnikolaiev olehnikolaiev deleted the bug/1963-wrong-max-fee-per-gas branch September 11, 2024 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@kladkogex kladkogex kladkogex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maxFeePerGas and maxPriorityFeePerGas are equal to 0 for type2 txns after eth_getTransaction call
3 participants
@olehnikolaiev @kladkogex @DmytroNazarenko