Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1980 fix mismatched v #1983

Merged
merged 9 commits into from
Sep 13, 2024
Merged

#1980 fix mismatched v #1983

merged 9 commits into from
Sep 13, 2024

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Sep 10, 2024

fixes #1980

fixed mismatched v field for type1 and type2 txns in txns json-rpc representation

tested on local machine comparing the results with geth
fixed unittests

no performance impact

before fix

  v: "0xf9454e86107da",
  value: 0,
  yParity: "0x1"

after fix

  v: "0x1",
  value: 0,
  yParity: "0x1"

@olehnikolaiev olehnikolaiev merged commit 25c3eb0 into develop Sep 13, 2024
6 checks passed
@olehnikolaiev olehnikolaiev deleted the bug/1980-mismatched-v branch September 13, 2024 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type-2 txs have mismatched v and yParity fields
3 participants