Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/1741 tracing api server #1940

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Enhancement/1741 tracing api server #1940

merged 6 commits into from
Jul 23, 2024

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Jul 9, 2024 •
edited
Loading

fixes #1741

moved tracing api to the separate json rpc server inside skaled

verified on local machine that debug api is only enabled with --enable-debug-apis option

verified on local machine that tracing api is only enabled with -DHISTORIC_STATE=1 option

tested by @oleksandrSydorenkoJ on the regression network

no performance impact

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@olehnikolaiev olehnikolaiev linked an issue Jul 10, 2024 that may be closed by this pull request
Move tracing API to a separate JSON RPC server #1741
Closed
@olehnikolaiev olehnikolaiev merged commit 96a9822 into v3.20.0 Jul 23, 2024
5 of 6 checks passed
@olehnikolaiev olehnikolaiev deleted the enhancement/1741-tracing-api-server branch July 23, 2024 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kladkogex kladkogex kladkogex approved these changes

@dimalit dimalit dimalit approved these changes

@DmytroNazarenko DmytroNazarenko Awaiting requested review from DmytroNazarenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move tracing API to a separate JSON RPC server
3 participants
@olehnikolaiev @dimalit @kladkogex