Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/is 833 selfdestruct rebased #1871

Closed
wants to merge 9 commits into from

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Apr 18, 2024

Description

selfdestruct instruction will fail if amount of storage used by this contract before transaction exceeds maxStorageForSelfdestruct. This behavior is activated by the SelfdestructStorageLimitPatch

see also https://github.com/skalenetwork/internal-support/issues/963

Tests

JsonRpcSuite/suicide_storage_limit

Performance Impact

Not expected

@dimalit dimalit marked this pull request as ready for review April 25, 2024 16:03
@kladkogex
Copy link
Collaborator

We cant disable self destruct since apps need it.

I am going to close this pull request and move the task to 2.5

@kladkogex kladkogex closed this Apr 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants