Enhancement/skaled 1583 patch architecture plus 17.2 #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-1583-patch-architecture-plus-17.2
|
SUGGESTIONS BEFORE MERGE:
|
kladkogex
previously approved these changes
Apr 11, 2024
olehnikolaiev
previously approved these changes
Apr 15, 2024
DmytroNazarenko
requested changes
Apr 15, 2024
| @@ -91,12 +91,13 @@ std::pair< bool, ExecutionResult > ClientBase::estimateGasStep( int64_t _gas, Bl | |||
| t.forceSender( _from ); | |||
| t.forceChainId( chainId() ); | |||
| t.ignoreExternalGas(); | |||
| EnvInfo const env( _latestBlock.info(), bc().lastBlockHashes(), 0, _gas ); | |||
| EnvInfo const env( _pendingBlock.info(), bc().lastBlockHashes(), | |||
| _pendingBlock.previousInfo().timestamp(), 0, _gas ); | |||
There was a problem hiding this comment.
Mb _pendingBlock.previousInfo().timestamp() -> _latestBlock.info().timestamp() would be better?
libethereum/ClientBase.cpp
Outdated
Comment on lines
120
to
124
| int64_t lowerBound = CorrectForkInPowPatch::isEnabledInWorkingBlock() ? | ||
| Transaction::baseGasRequired( !_dest, &_data, | ||
| bc().sealEngine()->chainParams().makeEvmSchedule( | ||
| bc().info().timestamp(), bc().number() ) ) : | ||
| Transaction::baseGasRequired( !_dest, &_data, EVMSchedule() ); |
There was a problem hiding this comment.
if/else would be more readable here
libethereum/SkaleHost.cpp
Outdated
Comment on lines
448
to
450
| static_cast< const Interface& >( m_client ) | ||
| .blockInfo( LatestBlock ) | ||
| .timestamp(), |
There was a problem hiding this comment.
This call could be retrieved and executed before loop
libethereum/SkaleHost.cpp
Outdated
| @@ -653,7 +654,8 @@ void SkaleHost::createBlock( const ConsensusExtFace::transactions_vector& _appro | |||
| // TODO clear occasionally this cache?! | |||
| if ( m_m_transaction_cache.find( sha.asArray() ) != m_m_transaction_cache.cend() ) { | |||
| Transaction t = m_m_transaction_cache.at( sha.asArray() ); | |||
| t.checkOutExternalGas( m_client.chainParams(), m_client.number(), true ); | |||
| t.checkOutExternalGas( m_client.chainParams(), | |||
| m_client.blockInfo( LatestBlock ).timestamp(), m_client.number(), true ); | |||
There was a problem hiding this comment.
m_client.blockInfo( LatestBlock ).timestamp() can be executed before loop
kladkogex
reviewed
Apr 16, 2024
kladkogex
approved these changes
Apr 17, 2024
DmytroNazarenko
approved these changes
Apr 17, 2024
dimalit
deleted the
enhancement/SKALED-1583-patch-architecture-plus-17.2
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1583
Description
Tests
Tests for patches:
JsonRpcSuite/simple_contractPerformance Impact
There can be significant performance impact, as patch activations are evaluated at each block or sometimes even every transaction. Quick testing with stability tests (skale-ci-intergration_tests) showed no significant difference between 3.19.0-develop-latest and 3.19.0-develop.3
Details about changes in code
blockNumberparameter now need alsocommittedBlockTimestamp.EVMSchedulecan now be constructed from several patches, and not only taken from pre-defined list as before (ChainOperationParams::evmSchedule)SealEnginetoChainOperationParams, andSealEngineis now unneeded in some places, whereChainOperationParamssuffice - for simplification of architecture. Also it's planned to cut out SealEngine completely.PushZeroPatchuses boolean field inEVMSchedule, and generates new EVMSchedule similar to 'fork blocks'libethereum/SchainPatch.hthere are new macros for creation of patches.SchainPatchclass.