Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1856_checkout_external_gas #1867

Merged
merged 2 commits into from
Apr 11, 2024
Merged

1856_checkout_external_gas #1867

merged 2 commits into from
Apr 11, 2024

Conversation

kladkogex
Copy link
Collaborator

@kladkogex kladkogex commented Apr 10, 2024 •
edited
Loading

Added ifndef HISTORIC_STATE to checkoutExternal gas as a fix for 2.3.1, in 2.4 we will not need this fix due to patch
architecture

Testing:

Tested using

npx hardhat run test/historicstate/scripts/trace.ts --network skaled

The call trace test was failing before, it is passing now

@kladkogex kladkogex added this to the SKALE 2.3.1 (Archive node) milestone Apr 10, 2024
@kladkogex kladkogex self-assigned this Apr 10, 2024
@kladkogex kladkogex linked an issue Apr 10, 2024 that may be closed by this pull request
checkOutExternalGas() check used for the historic blocks and leads to the failed request #1856
Closed
@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@kladkogex kladkogex merged commit 622187a into develop Apr 11, 2024
5 checks passed
@kladkogex kladkogex deleted the 1856_checkout_external_gas branch April 11, 2024 12:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@dimalit dimalit dimalit approved these changes

@olehnikolaiev olehnikolaiev Awaiting requested review from olehnikolaiev

Assignees

@kladkogex kladkogex

Labels
None yet
Projects
None yet
Milestone
SKALE 2.3.1 (Archive node)
Development

Successfully merging this pull request may close these issues.

checkOutExternalGas() check used for the historic blocks and leads to the failed request
3 participants
@kladkogex @dimalit @DmytroNazarenko