-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1850 historic node reset db #1854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUGGESTIONS BEFORE MERGE:
|
olehnikolaiev
approved these changes
Apr 8, 2024
DmytroNazarenko
approved these changes
Apr 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that
MANIFEST
file of historic state LevelDB was growing indefinitely.Since during restart
MANIFEST
file is read and processed, it led to extremely long opening times.leveldbReopenIntervalMs
The default value of
leveldbReopenIntervalMs
is one day or 24 * 60 * 60 * 1000 microseconds.If leveldbReopenIntervalMs is negative (like -1) than the features is disabled
Everytime there is a write batch to LevelDB (this typically happens after block processing) there is a check for the
age of LevelDB descriptor. If the descriptor age is more than
leveldbReopenIntervalMs
, the descriptor is closed and opened again.Reopen of the descriptor happens while holding write lock (inclusive lock) Use of the descriptor happens while holding read lock.
A new test
infinite_loop_test
is used to test the functionality. During the test, transactions are generated in the blockchain, whileleveldbReopenIntervalMs
is set to 1ms. Manifest file of leveldb is observed to see that it does not grow.Also readability of github tests were improved by adding --report_level=detailed options to testheth.
Now if one of test_eth tests fails, it is way faster to understand which test fails and get the error message