Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump node.js for github runner #1822

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Bump node.js for github runner #1822

merged 1 commit into from
Feb 16, 2024

Conversation

DmytroNazarenko
Copy link
Collaborator

@DmytroNazarenko DmytroNazarenko commented Feb 15, 2024 •
edited
Loading

Description

Bumping node.js version for functional-tests github runner

Tests

Test run: https://github.com/skalenetwork/skaled/actions/runs/7921219562

Performance Impact

No impact

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@DmytroNazarenko DmytroNazarenko linked an issue Feb 15, 2024 that may be closed by this pull request
Functional tests are failing during deps installation #1823
Closed
@DmytroNazarenko DmytroNazarenko marked this pull request as ready for review February 15, 2024 20:27
@DmytroNazarenko DmytroNazarenko merged commit 04f7543 into develop Feb 16, 2024
9 checks passed
@DmytroNazarenko DmytroNazarenko deleted the bump-node-js branch February 16, 2024 17:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olehnikolaiev olehnikolaiev olehnikolaiev approved these changes

@dimalit dimalit dimalit approved these changes

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functional tests are failing during deps installation
3 participants
@DmytroNazarenko @dimalit @olehnikolaiev