SKALED-1812 Use _enablePrivilegedApis in jsonrpc's Debug #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SUGGESTIONS BEFORE MERGE:
|
DmytroNazarenko
previously approved these changes
Feb 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.17.2 #1813 +/- ##
===========================================
+ Coverage 42.50% 42.57% +0.06%
===========================================
Files 392 392
Lines 57116 57116
===========================================
+ Hits 24279 24316 +37
+ Misses 32837 32800 -37 |
kladkogex
approved these changes
Feb 14, 2024
| @@ -346,7 +346,7 @@ struct JsonRpcFixture : public TestOutputHelperFixture { | |||
| rpcServer.reset( new FullServer( ethFace , new rpc::Net( chainParams ), | |||
| new rpc::Web3( /*web3->clientVersion()*/ ), // TODO Add real version? | |||
| new rpc::AdminEth( *client, *gasPricer, keyManager, *sessionManager.get() ), | |||
| /*new rpc::AdminNet(*web3, *sessionManager), */ new rpc::Debug( *client ), | |||
| /*new rpc::AdminNet(*web3, *sessionManager), */ new rpc::Debug( *client, nullptr, "", true), | |||
There was a problem hiding this comment.
Please remove dead code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests' fixture now uses _enablePrivilegedApis=true in Debug class.
Before that, test was failing because of disabled privileged access.