Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1785 fix unittests #1786

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Bug/1785 fix unittests #1786

merged 6 commits into from
Jan 17, 2024

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Jan 17, 2024

fixes #1785

fix some of the configs in unittests
fix the issue when failed tests were interpreted as passed

@olehnikolaiev olehnikolaiev changed the base branch from develop to v3.18.0 January 17, 2024 16:00
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0921108) 37.83% compared to head (d6427e7) 45.70%.
Report is 1 commits behind head on v3.18.0.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.18.0    #1786      +/-   ##
===========================================
+ Coverage    37.83%   45.70%   +7.87%     
===========================================
  Files          358      358              
  Lines        51820    51820              
===========================================
+ Hits         19604    23685    +4081     
+ Misses       32216    28135    -4081     

Copy link
Contributor

@dimalit dimalit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@olehnikolaiev olehnikolaiev merged commit 85146a0 into v3.18.0 Jan 17, 2024
11 checks passed
@olehnikolaiev olehnikolaiev deleted the bug/1785-fix-unittests branch January 17, 2024 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix unit tests
3 participants