-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1751 trace multiple transactions in a single block #1783
Merged
kladkogex
merged 42 commits into
v3.17.2
from
1751_trace_transaction_from_a_single_user
Jan 22, 2024
Merged
1751 trace multiple transactions in a single block #1783
kladkogex
merged 42 commits into
v3.17.2
from
1751_trace_transaction_from_a_single_user
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUGGESTIONS BEFORE MERGE:
|
kladkogex
changed the title
1751 trace transaction from a single user
1751 trace multiple transactions in a single block
Jan 15, 2024
kladkogex
force-pushed
the
1751_trace_transaction_from_a_single_user
branch
from
January 15, 2024 17:34
e458e6a
to
e6f7572
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v3.17.2 #1783 +/- ##
===========================================
- Coverage 42.63% 42.50% -0.13%
===========================================
Files 392 392
Lines 57013 57116 +103
===========================================
- Hits 24307 24279 -28
- Misses 32706 32837 +131 |
DmytroNazarenko
requested changes
Jan 19, 2024
DmytroNazarenko
approved these changes
Jan 22, 2024
olehnikolaiev
approved these changes
Jan 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT WAS FIXED
Trace was not working if a block has multiple transactions (from a single entity or from multiple entities)
Bug 1751 is a duplicate of 1750. Both are fixed by this commit,.
When the block was executed, receipts were not saved. Execution of a transaction requires receipt of the previous transaction since it includes the totalgas used so far. This is important for block gas limit.
Also the case when a transaction does not call a smartcontract (so the trace is empty) was not handled properly.
In the process of the fix, I made corresponding exceptions more informative and checked that exceptions are always handled
TESTS
I modified the test tracer.ts. Now the test inserts a transaction before the test transaction, so in the test the block
includes two transactions.
As before, the test runs as part of github actions.
Bug 1750 is a duplicate of 1751. Both are fixed by this commit,.