Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1749 debug trace call (#1771) #1772

Merged
merged 1 commit into from
Jan 3, 2024
Merged

1749 debug trace call (#1771) #1772

merged 1 commit into from
Jan 3, 2024

Conversation

kladkogex
Copy link
Collaborator

Fixed debug_traceCall and lots of compatibility issues with geth

Added tests to trace.ts for all trace types that compare results to geth traces

The tests run as part of github actions

# 1748 debug_traceCall
@kladkogex kladkogex added this to the 2.3 milestone Dec 27, 2023
@kladkogex kladkogex self-assigned this Dec 27, 2023
@kladkogex kladkogex linked an issue Dec 27, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 169 lines in your changes are missing coverage. Please review.

Comparison is base (8717699) 42.61% compared to head (b194ec1) 36.27%.
Report is 1 commits behind head on v3.17.2.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.17.2    #1772      +/-   ##
===========================================
- Coverage    42.61%   36.27%   -6.35%     
===========================================
  Files          392      392              
  Lines        56973    57013      +40     
===========================================
- Hits         24281    20682    -3599     
- Misses       32692    36331    +3639     

@kladkogex kladkogex merged commit a6a060f into v3.17.2 Jan 3, 2024
7 of 10 checks passed
@kladkogex kladkogex deleted the 1748_trace_call branch January 3, 2024 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaled returns error on valid debug_traceCall request
3 participants