-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/1640 slow catchup #1770
Merged
Merged
Bug/1640 slow catchup #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehnikolaiev
requested review from
DmytroNazarenko and
kladkogex
as code owners
December 27, 2023 11:40
SUGGESTIONS BEFORE MERGE:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.18.0 #1770 +/- ##
===========================================
- Coverage 45.56% 45.54% -0.02%
===========================================
Files 356 356
Lines 51762 51766 +4
===========================================
- Hits 23584 23576 -8
- Misses 28178 28190 +12 |
DmytroNazarenko
approved these changes
Jan 10, 2024
dimalit
approved these changes
Jan 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1640
drop txns coming through broadcast if skaled has outdated state - this will decrease RAM usage during catchup and help to increase performance
tested manually on devnet - performnace is good per @oleksandrSydorenkoJ