-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/skaled 1745 invalid fork in pow gas #1768
Bug/skaled 1745 invalid fork in pow gas #1768
Conversation
…nit test for estimateGas parameters" This reverts commit d467308.
SUGGESTIONS BEFORE MERGE:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v3.18.0 #1768 +/- ##
===========================================
+ Coverage 45.52% 45.56% +0.04%
===========================================
Files 356 358 +2
Lines 51709 51807 +98
===========================================
+ Hits 23542 23608 +66
- Misses 28167 28199 +32 |
11118c9
to
2feff86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please, add patch timestamp to estimateGas
- Update description with details about new patch timestamp
9f1de09
Changes:
1
Transaction::checkOutExternalGas()
now operates on current Ethereum fork, instead of Constantinople (base gas for 1 byte of data changed from 68 gas/b to 16 gas/b)2 All changes are activated after
correctForkInPowPatchTimestamp
. This is true both for external gas check and for eth_estimateGas call.3
Transaction::checkOutExternalGas()
is called one additional time after consensus (needed to be sure that patch activates smoothly). This make possible little decrease of block processing performance (but unlikely).Testing:
JsonRpcSuite/simplePoWTransaction tests that PoW transaction with incorrect amount of gas fails before patch timestamp and works after it