Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKALED-1431 debug_getFutureTransactions call #1761

Closed
wants to merge 7 commits into from

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Dec 15, 2023

Rebased from v3.18.0 to v3.17.2

Test sequence:

  1. Add balance for your account to skaled's config.
  2. Run skaled with --enable-debug-behavior-apis
  3. Send transaction with too big nonce.
  4. Send curl -X POST --data '{"id":4,"jsonrpc":"2.0","method":"debug_getFutureTransactions","params":[]}'
  5. See your transaction.
  6. Repeat the same without --enable-debug-behavior-apis, METHOD_NOT_FOUND error should be returned.

@dimalit dimalit linked an issue Dec 15, 2023 that may be closed by this pull request
@dimalit dimalit marked this pull request as ready for review December 15, 2023 18:59
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 187 lines in your changes are missing coverage. Please review.

Comparison is base (8717699) 42.61% compared to head (2a30c8b) 42.63%.
Report is 2 commits behind head on v3.17.2.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.17.2    #1761      +/-   ##
===========================================
+ Coverage    42.61%   42.63%   +0.01%     
===========================================
  Files          392      392              
  Lines        56973    57036      +63     
===========================================
+ Hits         24281    24317      +36     
- Misses       32692    32719      +27     

@DmytroNazarenko DmytroNazarenko marked this pull request as draft January 10, 2024 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tool to get list of transactions from future transaction queue
2 participants